Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

highlighting of $(...) #83

Closed
ExpandingMan opened this issue Nov 7, 2016 · 3 comments
Closed

highlighting of $(...) #83

ExpandingMan opened this issue Nov 7, 2016 · 3 comments

Comments

@ExpandingMan
Copy link
Contributor

There is one more minor highlighting issue that remains: the boundaries of literal substitutions within expressions like $(...). To conform with the highlighting of $x and :(...), the characters $, (, ) would be highlighted.

Anyway @carlobaldassi just finished doing a great job on implementing symbol highlighting, and I thought I should express my appreciation for that after raising this other, probably rather obnoxious issue 😺.

@carlobaldassi
Copy link
Contributor

These are highlighted within Strings, but not in quoted expressions. Again, it boils down to the difficulty of disambiguating with the $ used as xor. I think the easiest thing to do i wait for that use of $ to become deprecated, after which this can be safely implemented (until it's picked up for something else, of course). (Also thanks for the appreciation.)

@carlobaldassi
Copy link
Contributor

Oh well.

@ExpandingMan
Copy link
Contributor Author

Awesome, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants