Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README mistake? #35

Closed
mauro3 opened this issue Sep 29, 2017 · 3 comments
Closed

README mistake? #35

mauro3 opened this issue Sep 29, 2017 · 3 comments

Comments

@mauro3
Copy link

mauro3 commented Sep 29, 2017

It claims in the README that "that it [null] essentially becomes a NaN for any type". IMO, one essential feature of NaN is NaN==NaN returns false. This is not the case for null. Maybe this should be clarified?
@cjprybol
Copy link
Contributor

cjprybol commented Sep 29, 2017 •
edited
Loading

This behavior changed in #33. You're correct that the README is now wrong for the master branch. The NaN behavior is still in place for the latest release, however. Sorry, null==null is true for the current release, so that's the reverse of the NaN behavior you described. Should definitely be fixed

@ararslan
Copy link
Member

Actually null == null is no longer true, as of a recent PR; it's now null.

@nalimilan nalimilan mentioned this issue Sep 30, 2017
Merged
@nalimilan
Copy link
Member

Good catch. I've filed #36, taking the occasion to develop and update the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nalimilan @cjprybol @mauro3 @ararslan