Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve inconsistencies with functions startof, endof, firstindex, lastindex #910

Open
claud10cv opened this issue Aug 13, 2024 · 2 comments

Comments

@claud10cv
Copy link

Functions startof, endof seem to have been deprecated, in favor of firstindex, lastindex, respectively, but they have been inconstently updated. In the reference below, startof remains the only possibility (firstindex(m::SortedMultiDict) for instance does not exist), while the opposite occurs with lastindex which seems to have replaced the method endof.

https://github.com/JuliaCollections/DataStructures.jl/blob/3776698802d7ee1581a60f006abd351ea69588cf/src/tokens2.jl#L9C1-L19C68

Moreover, the doc still reflects the old syntax (startof, endof) as current, see for instance https://juliacollections.github.io/DataStructures.jl/stable/sorted_containers/#Tokens-for-Sorted-Containers-1

@oxinabox
Copy link
Member

Yes, this is part of #479.
We are struggling with not having enough julia developers
who both have the experience to recognize these inconsistencies.
and the time to contribute to the package.

Would you be interested in doing so?
I can review.

@StephenVavasis
Copy link
Contributor

The documentation quoted in the OP message is not the most recent version. Please see the "dev" version of the docs and the package, which implements firstindex and lastindex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants