Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make processing of images easier via multiple dispatch #276

Closed
rikhuijzer opened this issue Apr 6, 2022 · 1 comment · Fixed by #285
Closed

Make processing of images easier via multiple dispatch #276

rikhuijzer opened this issue Apr 6, 2022 · 1 comment · Fixed by #285

Comments

@rikhuijzer
Copy link
Collaborator

rikhuijzer commented Apr 6, 2022

The logic for processing images should be more easily user-extendable by allowing people to add extra image types and how to convert the image to SVG and PNG. So, interface could be as follows:

Books.svg(path, p::ExternalPlottingLibrary.Figure) = ExternalPlottingLibrary.save_svg(p)
Books.png(path, ...) = ...
@rikhuijzer
Copy link
Collaborator Author

And just make this the default way to handle extra dependencies. For someone who writes a book, adding a few methods like this shouldn't be too bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant