-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add remaining static clustering models #19
Comments
Hi @ablaom Affinity Propagation is used in the study that I am working on, but its interface hasn't been implemented in this package yet. Is there anything I should pay attention to if I have time to implement it next week? |
Many thanks for the offer of help! My only comment is that this looks like a Assuming that is the case, you can use DBSCAN as a template. See here for the workflow you would be supporting. |
It turns out I have some time in the weekend so I have drafted a PR (#28). As for your question, the model looks a lot like |
Mmm. If it's a truly static model (no generalisation) you can't use KMedoids without some changes:
|
Judging from the algorithm of the model, I don't think the model can generalize to new data instances. (One can determine which exemplar a datum is closest to, but that's not necessarily a reasonable classifier for out-of-sample data.) It's better to implement it as a |
Great. Ping me when you are ready for review. No rush. |
This is now merged. For @ablaom to do:
cc @Yuan-Ru-Lin |
I have existing PRs addressing some of the unchecked boxes One is JuliaAI/MLJModels.jl#574, the other is JuliaAI/MLJ.jl#1147. EDIT: add a PR |
https://juliastats.org/Clustering.jl/stable/
@OkonSamuel
The text was updated successfully, but these errors were encountered: