Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3 event handlers leaking memory: ContextMenu (used by TreeView) and DragDrop (used by DropDown) #172

Open
Jemt opened this issue Nov 20, 2022 · 0 comments

Comments

@Jemt
Copy link
Owner

Jemt commented Nov 20, 2022

The following regular expression search reveals that anonymous global event handlers are registered without the possibility to unregister them since the returned event ID is not stored and therefore not used to unregister.

(^| )Fit\.Events\.AddHandler\((document|window).*function\(

image

The matches in Core/Events.js are okay - these are event handlers supposed to remain in effect at all times. But the event handler in ContextMenu.js and the two event handlers in DragDrop.js are never removed and therefore leaking memory. ContextMenu is used in TreeView and DragDrop is used in DropDown (which may also use Treeview), so using any of these may cause memory to leak as well.

Also see #155 (Events: Memory leak for event handlers)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant