Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: Porting to nodejs AsyncLocalStorage #57

Open
Ghost---Shadow opened this issue May 3, 2020 · 3 comments
Open

Discussion: Porting to nodejs AsyncLocalStorage #57

Ghost---Shadow opened this issue May 3, 2020 · 3 comments

Comments

@Ghost---Shadow
Copy link

Since node 13 AsyncLocalStorage has been added.

https://nodejs.org/api/async_hooks.html#async_hooks_class_asynclocalstorage

I think we should port to that.

The API looks fairly clean.

@kylemillar608
Copy link

Are there any plans to do this? nodejs/node#35286 - seems like this API is much closer to being stable than Async Hooks.

@SimonX200
Copy link

For our project the plain AsyncLocalStorage is enough.

To me it looks like the porting is only useful to keep the cls-hooked API and have an updated npm package to existing projects.

I think actually that the porting will result in just a wrapping of AsyncLocalStorage methods to the cls-hook api names.

@m0uneer
Copy link

m0uneer commented Jan 24, 2022

And why not @SimonX200?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants