Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "solid with marker color" view mode from #2316 #2331

Merged
merged 3 commits into from
May 31, 2024

Conversation

Azagwen
Copy link
Contributor

@Azagwen Azagwen commented May 12, 2024

This pull request adds the view mode requested in #2316
At the moment localization seems to not be working (on my end only ?), even tho I have added entries in the lang files of which I speak the language, I haven't managed to find why.

What I did here is basically duplicate the "solid" view mode and its associated canvas & preview setup, but with an added marker color component, just like the default "texture" view mode already has

Demo Video (recorded on the netify preview to have working localization)

firefox_GeJimwvzmQ.mp4

Copy link

netlify bot commented May 12, 2024

Deploy Preview for blockbench-dev ready!

Name Link
🔨 Latest commit a565e72
🔍 Latest deploy log https://app.netlify.com/sites/blockbench-dev/deploys/66410066db2d6300080ba86c
😎 Deploy Preview https://deploy-preview-2331--blockbench-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JannisX11
Copy link
Owner

You should only add localized strings to the english language file, all other languages are handled by the POEditor project. After adding translations, you can run npm run bundle to build it locally and properly see those translations.

@Azagwen
Copy link
Contributor Author

Azagwen commented May 12, 2024

You should only add localized strings to the english language file, all other languages are handled by the POEditor project. After adding translations, you can run npm run bundle to build it locally and properly see those translations.

Oh! Okay, that makes sense, I'll remove the other translation I had added then
And running that did work, good to know 😄

@Azagwen
Copy link
Contributor Author

Azagwen commented May 12, 2024

I just tested with the custom Marker Color plugin, Canvas freezes and spits errors 🥲
Will investigate

EDIT: Fixed it

@Azagwen Azagwen changed the title added "solid with marker color" view mode as requested by #2316 Added "solid with marker color" view mode from #2316 May 13, 2024
@JannisX11 JannisX11 merged commit 475f6ff into JannisX11:next May 31, 2024
4 checks passed
@Azagwen Azagwen deleted the next branch June 16, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants