Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect handling of images in GLTF exporter when Embed Textures is off #2510

Closed
MattiDragon opened this issue Oct 12, 2024 · 0 comments
Closed

Comments

@MattiDragon
Copy link

What are you trying to do, and what do you expect to happen?

When I export a model to GLTF with Embed Textures disabled, I expect blockbench to output a valid GLTF file with something resonable as the uri field of the images.

What happens instead?

Blockbench creates an invalid GLTF file where images lack the uri field. This is because the code that sets the uri field ends up setting it to undefined because the canvas used as image in the three.js texture doesn't have a src attribute. I'm not sure where blockbench should get the uri from, but it should definatly exist in the file.

Model format in which the issue occurs

GLTF

Blockbench variant

Program

Blockbench version

v4.11.1

Operating System

Windows 11 Home

Installed Blockbench plugins

None

@JannisX11 JannisX11 moved this from To triage to In review in Blockbench Issues Oct 27, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in Blockbench Issues Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

1 participant