Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Texture field in bedrock entity project defaults to bool false instead of expected no definition #2340

Closed
imIrony opened this issue May 15, 2024 · 1 comment
Labels
bug An issue, where the program does not do what it is supposed to

Comments

@imIrony
Copy link

imIrony commented May 15, 2024

What are you trying to do, and what do you expect to happen?

Saving a Blockbench project in bedrock entity format should resolve the texture field within a faces object array as an int if there is a valid texture or removed completely if there isn't a valid texture.

What happens instead?

Saving a Blockbench project in bedrock entity format causes the texture field within a faces object array to resolve as a bool false if there isn't a valid texture and as an int if there is a valid texture.

Unsure if this change was made intentionally, if so please close this issue with confirmation. Currently doesn't make sense for texture to accept 2 different types in this scenario.

Model format in which the issue occurs

Bedrock Entity

Blockbench variant

Program

Blockbench version

4.10.1

Operating System

Windows 11

Installed Blockbench plugins

No response

@JannisX11
Copy link
Owner

This was a versioned change to resolve an issue where saving and opening a project would assign textures to faces explicitly, in formats that are single-texture based and shouldn't have textures explicitly assigned to faces: https://www.blockbench.net/wiki/

However, you are right, the field should be omitted in this case instead of being set to false. false is consistent with how the data is handled internally, but to be consistent with previous versions of the bbmodel format, omitting the field would actually be correct.

@JannisX11 JannisX11 added the bug An issue, where the program does not do what it is supposed to label May 15, 2024
@JannisX11 JannisX11 moved this from To triage to Backlog in Blockbench Issues May 25, 2024
@JannisX11 JannisX11 moved this from Backlog to In review in Blockbench Issues May 26, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in Blockbench Issues May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue, where the program does not do what it is supposed to
Projects
Status: Done
Development

No branches or pull requests

2 participants