Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: export image of the current theme #613

Merged
merged 2 commits into from
Apr 11, 2021
Merged

feat: export image of the current theme #613

merged 2 commits into from
Apr 11, 2021

Conversation

JanDeDobbeleer
Copy link
Owner

@JanDeDobbeleer JanDeDobbeleer commented Apr 4, 2021 •
edited
Loading

Prerequisites

  • I have read and understand the CONTRIBUTING guide
  • The commit message follows the conventional commits guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Description

The ability to export a png with the current configuration.

image

To-Do

  • Strip unneeded ANSI characters
  • Create helper functions in init scripts
  • Create docs
  • Create a generated themes page on docs deploy

@JanDeDobbeleer
Copy link
Owner Author

@travistx I still need to tweak the export properly but with some minor bugs it's already working :-)

@JanDeDobbeleer JanDeDobbeleer marked this pull request as draft April 5, 2021 06:05
@JanDeDobbeleer JanDeDobbeleer force-pushed the export-png branch 18 times, most recently from 0db3f07 to 612eca2 Compare April 9, 2021 19:15
@JanDeDobbeleer JanDeDobbeleer force-pushed the export-png branch 8 times, most recently from 9ff02dc to 8fef212 Compare April 11, 2021 08:27
@JanDeDobbeleer JanDeDobbeleer marked this pull request as ready for review April 11, 2021 08:52
@JanDeDobbeleer JanDeDobbeleer merged commit afb69b4 into main Apr 11, 2021
@JanDeDobbeleer JanDeDobbeleer deleted the export-png branch April 11, 2021 08:53
@tradiff
Copy link
Contributor

tradiff commented Apr 11, 2021

@JanDeDobbeleer Congrats on launching this feature! The new themes page looks awesome! 😍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JanDeDobbeleer @tradiff