Use \r\n instead of \n for multi lines prompt to avoid some bug
#5936
Replies: 4 comments 5 replies
-
|
@mrbeardad wait, that shouldn't happen at all. Let me double check this. |
Beta Was this translation helpful? Give feedback.
-
|
@mrbeardad ok, so, can't reproduce this. Is your WT up to date? If it incorrectly calculates some of the cion's width's, this is exactly what will happen. |
Beta Was this translation helpful? Give feedback.
-
|
@JanDeDobbeleer I found this issue when I use Psfzf tab completion, it could be reproduced just after |
Beta Was this translation helpful? Give feedback.
-
20241126-102744.mp4It could be fixed by replacing the |
Beta Was this translation helpful? Give feedback.
-
|
@mrbeardad I'm testing this change to understand if it doesn't break anything. If not, consider this done. |
Beta Was this translation helpful? Give feedback.
-
|
@mrbeardad this needs to be reverted as |
Beta Was this translation helpful? Give feedback.
-
|
It could be reproduced easily in a terminal that has small width, then press $Global:__OriginalPrompt = $function:Prompt
function prompt {
# Place at beginning of function to avoid oh-my-posh get the wrong last error code
$out = $Global:__OriginalPrompt.Invoke()[0];
# Transient prompt
if ($out[-1] -eq "`b") {
return $out
}
# Replace \n to \r\n to avoid some bug
$out = $out -replace "`n","`r`n"
# Reset the cursor to the correct shape
if ($Global:PsReadLineViMode -eq "i") {
$out += $PsReadLineViInsertModeCursor
} else {
$out += $PsReadLineViNormalModeCursor
}
return $out
} |
Beta Was this translation helpful? Give feedback.
-
|
@mrbeardad Yes, but it only happens when using FzF, never when the prompt is printed normally. So, something is influencing the calculation in oh-my-posh incorrectly. I want to understand what that is because that is the bug and this is a patch. |
Beta Was this translation helpful? Give feedback.
-
|
@JanDeDobbeleer It seems to be related to https://vt100.net/docs/vt510-rm/LNM.html, however, setting new line mode works sometime, not always |
Beta Was this translation helpful? Give feedback.
-
Code of Conduct
What happened?
change the
\nto\r\nwill fix this issueTheme
https://github.com/mrbeardad/MyIDE/blob/master/powershell/base16_bear.omp.json
What OS are you seeing the problem on?
Windows
Which shell are you using?
powershell
Log output
Beta Was this translation helpful? Give feedback.
All reactions