Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

COMP: Get ITK_USE_FLOAT_SPACE_PRECISION=ON to compile again #4805

Closed
wants to merge 1 commit into from
Closed

COMP: Get ITK_USE_FLOAT_SPACE_PRECISION=ON to compile again #4805

wants to merge 1 commit into from

Conversation

dzenanz
Copy link
Member

@dzenanz dzenanz commented Aug 16, 2024

Closes #4802.

PR Checklist

@dzenanz dzenanz requested a review from seanm August 16, 2024 14:28
@dzenanz dzenanz changed the base branch from master to release August 16, 2024 14:28
@github-actions github-actions bot added type:Compiler Compiler support or related warnings area:Examples Demonstration of the use of classes type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct area:Core Issues affecting the Core module area:Filtering Issues affecting the Filtering module area:IO Issues affecting the IO module labels Aug 16, 2024
@dzenanz dzenanz requested a review from thewtex August 16, 2024 14:46
seanm
seanm reviewed Aug 19, 2024
View reviewed changes
Copy link
Contributor

@seanm seanm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm generally.

Modules/Filtering/LabelMap/include/itkShapeLabelMapFilter.hxx Show resolved Hide resolved
@dzenanz
Copy link
Member Author

dzenanz commented Aug 19, 2024

/azp run ITK.Linux

This was referenced Aug 19, 2024
Closed
Closed
Merged
@seanm
Copy link
Contributor

seanm commented Aug 21, 2024

+1 for me, but there's still a red X on CI.

@dzenanz dzenanz marked this pull request as draft August 21, 2024 14:26
@dzenanz
Copy link
Member Author

dzenanz commented Aug 21, 2024

Thanks for review, Sean. This PR is being superseded by #4811.

@dzenanz
Copy link
Member Author

dzenanz commented Aug 21, 2024

Closing in favor of #4811.

@dzenanz dzenanz closed this Aug 21, 2024
@dzenanz dzenanz deleted the spacePrecision branch August 21, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanm seanm seanm left review comments

@thewtex thewtex Awaiting requested review from thewtex

Assignees
No one assigned
Labels
area:Core Issues affecting the Core module area:Examples Demonstration of the use of classes area:Filtering Issues affecting the Filtering module area:IO Issues affecting the IO module type:Compiler Compiler support or related warnings type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Is ITK_USE_FLOAT_SPACE_PRECISION obsolete? Build errors when = YES.
2 participants
@dzenanz @seanm