Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telegram's latest version is changing after every refresh #2025

Open
Marocco2 opened this issue Dec 10, 2024 · 25 comments
Open

Telegram's latest version is changing after every refresh #2025

Marocco2 opened this issue Dec 10, 2024 · 25 comments
Labels
bug Something isn't working

Comments

@Marocco2
Copy link
Contributor

Marocco2 commented Dec 10, 2024

Prerequisites

Add Telegram via Obtainium preset on the website

Describe the bug

Obtainium doesn't pick up a stable latest version of Telegram and it will message about a new version release

To Reproduce

  1. Go to Telegram page
  2. Refresh

Screenshots and Logs

screen-20241210-121209.mp4

Please complete the following information:

  • Device: Pixel 8 Pro
  • OS: GrapheneOS
  • Obtainium Version: V1.1.34

Additional context

@Marocco2 Marocco2 added bug Something isn't working to check Issue has not been reviewed labels Dec 10, 2024
@ImranR98
Copy link
Owner

This is likely due to #2027 (the setting gets reset for some reason). For now, you can manually change the "Pseudo-Versioning Method" back to "Partial APK Hash" and then mark as updated.

@ImranR98 ImranR98 added blocked This is dependent on external changes and removed to check Issue has not been reviewed labels Dec 10, 2024
@Marocco2
Copy link
Contributor Author

For now, you can manually change the "Pseudo-Versioning Method" back to "Partial APK Hash" and then mark as updated.

I can't. It's imported as DirectApkLink, not HTML (which I don't know how to set up)

@DarkCrypt
Copy link

I understand the reason to remove Telegram as a dedicated source but I fail to understand why the config website is using "Direct APK Link". I have a config for "HTML" source if you want me to post it?

@Revival8697
Copy link

Revival8697 commented Dec 11, 2024

The version of Telegram can be checked by querying APP_VERSION_NAME from https://raw.githubusercontent.com/DrKLO/Telegram/refs/heads/master/gradle.properties.

@leo-liar
Copy link

I just checked (after the Obtainium update switching Telegram to a regular HTML setup) and I also don't see the regular HTML config page (only a subset of options and no way to change pseudo-versioning)!

@Marocco2
Copy link
Contributor Author

I understand the reason to remove Telegram as a dedicated source but I fail to understand why the config website is using "Direct APK Link". I have a config for "HTML" source if you want me to post it?

Please share. The alternative is utter garbage for me 🙏

@DarkCrypt
Copy link

DarkCrypt commented Dec 11, 2024

Edit:
Removed config.

@ImranR98
Copy link
Owner

Default Pseudo-Versioning Method: APK Link Hash

This will not work because the APK link is https://telegram.org/dl/android/apk - it doesn't change when updates are released so the hash won't change and Obtainium won't know there has been an update.

@ImranR98
Copy link
Owner

And you're right, Telegram was converted to a "Direct APK Link" source, not HTML. I confused this for the WhatsApp issue #2022. @Marocco2 you'll need to keep using the pseudo-version - just tap the "mark as updated" button.

@ImranR98 ImranR98 closed this as not planned Won't fix, can't repro, duplicate, stale Dec 12, 2024
@ImranR98 ImranR98 removed the blocked This is dependent on external changes label Dec 12, 2024
@DarkCrypt
Copy link

My above config retrieves the apk from the same link as the "Direct APK Link". I understand your reason for why my config won't work. So the "Direct APK Link" works because it doesn't check for the hash?

@ImranR98
Copy link
Owner

ImranR98 commented Dec 13, 2024

Your config doesn't work because it uses the APK link hash - if you switch to "partial APK hash", it will work (this means hashing the first few KB of the APK itself to see if it has changed). That's what the "direct APK link" source does, but it skips the unnecessary step of loading the HTML page first (telegram.org/android).

@plusmeup
Copy link

Your config doesn't work because it uses the APK link hash - if you switch to "partial APK hash", it will work (this means hashing the first few KB of the APK itself to see if it has changed). That's what the "direct APK link" source does, but it skips the unnecessary step of loading the HTML page first (telegram.org/android).

How to switch to "Partial APK hash" then?
I have the same problem and it's frustrating.

@ImranR98
Copy link
Owner

Should be in the app config settings (pencil icon on the bottom left)

@plusmeup
Copy link

Should be in the app config settings (pencil icon on the bottom left)

Which one exactly?
Screenshot_20241213-105709

@ImranR98
Copy link
Owner

Are you on the latest version?

@ImranR98
Copy link
Owner

Not sure why you don't have the dropdown:
Screenshot_20241213-030550

@plusmeup
Copy link

Are you on the latest version?

Yes, 1.1.36

@plusmeup
Copy link

Not sure why you don't have the dropdown: Screenshot_20241213-030550

I don't know why either. I don't have it for all of my apps.

@ImranR98
Copy link
Owner

That's weird - please open a new issue. For Telegram specifically ypu should be using the direct link config anyways, available on apps.obtainium.imranr.dev.

@plusmeup
Copy link

That's weird - please open a new issue. For Telegram specifically ypu should be using the direct link config anyways, available on apps.obtainium.imranr.dev.

Okay. I'm already using the direct link config from your website.

@ImranR98
Copy link
Owner

Oh, I see. The "Partial APK hash" option is only relevant to the HTML source which is what was being discussed above. So you should be good. Are you seeing the constant version changes still? This issue was about the version constantly changing on every refresh. If you only saw the version change once (from "x.y.z" to a series of random numbers) then that is normal and expected - read above and the wiki for details.

@plusmeup
Copy link

plusmeup commented Dec 13, 2024

Oh, I see. The "Partial APK hash" option is only relevant to the HTML source which is what was being discussed above. So you should be good. Are you seeing the constant version changes still? This issue was about the version constantly changing on every refresh. If you only saw the version change once (from "x.y.z" to a series of random numbers) then that is normal and expected - read above and the wiki for details.

I get that it's expected, but Telegram updates constantly even after being marked as updated, despite having no new releases. These updates don't do anything but refresh this pseudo-version number string.

@Marocco2
Copy link
Contributor Author

Oh, I see. The "Partial APK hash" option is only relevant to the HTML source which is what was being discussed above. So you should be good. Are you seeing the constant version changes still? This issue was about the version constantly changing on every refresh. If you only saw the version change once (from "x.y.z" to a series of random numbers) then that is normal and expected - read above and the wiki for details.

I get that it's expected, but Telegram updates constantly even after being marked as updated, despite having no new releases. These updates don't do anything but refresh this pseudo-version number string.

Which is exactly what this issue was for

@ImranR98 ImranR98 reopened this Dec 13, 2024
@leo-liar
Copy link

leo-liar commented Dec 13, 2024

I do observe the same as user plusmeup:

Near constant update notifications for Telegram despite there being no new version and only the pseudo version string getting updated.
My config also looks like shown above with no settings entry for switching to partial APK hash.

I had Telegram set up before and got switched to the current setting by the recent Obtainium update. I'm also on the latest version 1.1.36 ...


Edit:
I just removed and then re-added Telegram (via https://apps.obtainium.imranr.dev/) to no avail. Still no option to change to partial APK hashing.

@DarkCrypt
Copy link

Your config doesn't work because it uses the APK link hash - if you switch to "partial APK hash", it will work (this means hashing the first few KB of the APK itself to see if it has changed). That's what the "direct APK link" source does, but it skips the unnecessary step of loading the HTML page first (telegram.org/android).

@ImranR98
Thank you for the explanation. I changed to "Partial APK Hash" and my config was able to update to the new release (v.11.5.4) like you said. I guess I prefer the "HTML" source because it provides more options even though it's not necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants