Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding pyrealm #638

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Adding pyrealm #638

wants to merge 6 commits into from
+942 −811

Conversation

davidorme
Copy link
Collaborator

@davidorme davidorme commented Dec 13, 2024 •
edited
Loading

Description

This PR is just to add pyrealm==2.0.0-rc.1 to the project requirements for use in the Plants model.

The timing of this PR also hits an update in mypy that revealed some class testing issues and the upgrade to Numpy 2.2.0 that changes typing and also raises issues. So this PR fixes the class typing and holds Numpy back from 2.2.0 just until the guidance on typing settles down.

Fixes #637 (issue)

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works
  • Relevant documentation reviewed and updated

@davidorme davidorme linked an issue Dec 13, 2024 that may be closed by this pull request
Import pyrealm #637
Open
@davidorme davidorme requested a review from vgro December 13, 2024 19:42
@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.62%. Comparing base (1a92bef) to head (e5186fd).
Report is 4 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop     #638   +/-   ##
========================================
  Coverage    94.62%   94.62%           
========================================
  Files           73       73           
  Lines         4617     4617           
========================================
  Hits          4369     4369           
  Misses         248      248

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

vgro
vgro approved these changes Dec 14, 2024
View reviewed changes
Copy link
Collaborator

@vgro vgro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me, my only question is do you need ^ before the version ?

@davidorme
Copy link
Collaborator Author

@vgro You're right, there was a better way of doing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vgro vgro vgro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Import pyrealm
3 participants
@davidorme @codecov-commenter @vgro