Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve annotation styles #253

Merged
merged 5 commits into from
Dec 9, 2024
Merged

Conversation

pedrokohler
Copy link
Collaborator

@pedrokohler pedrokohler commented Nov 20, 2024

Addresses

#184 (comment) (i.e.: fix unexpected color change when selecting annotations)
#184 (comment) (i.e.: add ability of using only outlines or showing filled annotations)
and
#184 (comment) (i.e.: add overlay of multiple annotations on hover)

Copy link
Collaborator

@igoroctaviano igoroctaviano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please describe the changes in the PR, address sonarcube issue and if possible, add documentation to new methods.

@igoroctaviano
Copy link
Collaborator

Please describe the changes in the PR, address sonarcube issue and if possible, add documentation to new methods.

@pedrokohler Also please update PR. I'll merge this PR and then cut a new release.

Copy link
Collaborator

@igoroctaviano igoroctaviano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarcloud bot commented Dec 9, 2024

@pedrokohler pedrokohler merged commit b65b459 into master Dec 9, 2024
7 of 8 checks passed
@fedorov
Copy link
Member

fedorov commented Dec 9, 2024

@pedrokohler could you please update the idc-slim fork with this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants