Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notes field for Caver & Cave #27

Closed
IdlePhysicist opened this issue Sep 4, 2020 · 3 comments · Fixed by #28
Closed

Notes field for Caver & Cave #27

IdlePhysicist opened this issue Sep 4, 2020 · 3 comments · Fixed by #28
Milestone

Comments

@IdlePhysicist
Copy link
Owner

Think about adding a note field to the caver/person table. The same could be done for caves/locations too. In fact that might be of more use.

These notes should only be viewable through an inspection view. Which would mean re-implementing that for the Caver and Cave panes.


Luckily I had just commented out most of the GUI code for displaying inspection windows. The db and model package will require more work along with the Python scripts which generate the databases.

I should point out that this will be a breaking change, meaning that people’s existing databases will not work and will need to be migrated. A migration could potentially be done in Python, meaning the script would read the file and determine if it had the right columns, then insert those columns if they are missing. I will need to brush up on SQLite to see how to do that.

@IdlePhysicist
Copy link
Owner Author

ALTER TABLE table_name ADD new_column_name column_definition;

@IdlePhysicist
Copy link
Owner Author

IdlePhysicist commented Sep 4, 2020

Since this would be a breaking change it might be best to schedule this for a v2.1.0 milestone.
It would only break if the app tried to read an old spec database.

@IdlePhysicist
Copy link
Owner Author

Closed by PR #28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant