Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overhead in getPropertySamples with 'visual' #52

Closed
BBallnus opened this issue Mar 3, 2017 · 3 comments
Closed

overhead in getPropertySamples with 'visual' #52

BBallnus opened this issue Mar 3, 2017 · 3 comments

Comments

@BBallnus
Copy link
Contributor

BBallnus commented Mar 3, 2017

I recently realized that getPropertySamples is very slow (43s for 2k sample iterations) in the conversionReaction example.

The largest portion (29s) of time goes into the 21 calls of plotPropertyUncertainty which updates the legend and histogram bars each time. Indeed, it updates every 100 MCMC iterations as coded in line 119 of getPropertySamples:

    if (mod(j,100) == 0) || (j == length(properties.S.logPost))

I suggest to change it to 10%, 20%, ... of the iterations instead or removing the sequential drawing entirely.

@dweindl
Copy link
Member

dweindl commented Mar 3, 2017

Sounds good. Maybe add it as an option with 10% as default?

@JanHasenauer
Copy link
Member

Agreed.

At some point one might include an adaptive strategy based on the expected computation time.

@BBallnus
Copy link
Contributor Author

BBallnus commented Mar 3, 2017

Ok, I changed the code to a percentage heuristic for now and gonna merge it into development in near future. An adaptive strategy sounds good. I'd suggest we implement it together with the modularization / expansion of the visularization tools as mentioned in issue #49

@BBallnus BBallnus closed this as completed Mar 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants