fix: allow retries and disable ssl to co-exist #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
padamstx
commented
Jan 31, 2022
padamstx
commented
Jan 31, 2022
padamstx
commented
Jan 31, 2022
padamstx
force-pushed
the
fix-disable-ssl
branch
3 times, most recently
from
4aca49c to
4b4979f
Compare
Previously, the "disable ssl" and "auto retries" scenarios were mutually exclusive due to the way in which the http client instances were managed. The result was that you could not enable retries and also disable ssl verification. This commit fixes this problem by adding more precise code to configure the "disable ssl" feature and also reuses existing client instances where possible.
padamstx
force-pushed
the
fix-disable-ssl
branch
from
4b4979f to
6dda58f
Compare
dpopp07
approved these changes
Feb 1, 2022
padamstx
pushed a commit
that referenced
this pull request
Feb 2, 2022
## [5.9.2](v5.9.1...v5.9.2) (2022-02-02) ### Bug Fixes * allow retries and disable ssl to co-exist ([#154](#154)) ([b16fe8d](b16fe8d))
|
🎉 This PR is included in version 5.9.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the "disable ssl" and "auto retries"
scenarios were mutually exclusive due to the way in
which the http client instances were managed.
The result was that you could not enable retries
and also disable ssl verification.
This commit fixes this problem by adding more precise
code to configure the "disable ssl" feature and
also reuses existing client instances where possible.