Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review code to ensure 'version' is not necessarily unique #85

Open
appukuttan-shailesh opened this issue Sep 1, 2020 · 0 comments
Open

Comments

@appukuttan-shailesh
Copy link
Collaborator

@apdavison proposed that:
model version does not have to be unique, but rather the combination of version and parameters should be considered unique.

You can have two model instances with the same code version but different parameters.

I had always worked with the presumption that version for instances was similar to alias for models/tests (a human readable unique identifier, as opposed to the UUID). All my implementations were with this understanding, and I believe even the unit tests were written to test only this aspect. So parts of the codebase could be faulty for this scenario.

The code for the python client and unit tests would need to be reviewed and updated, where required, to handle this.

To be decided: if the same rule should apply for test instances

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant