Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timepicker ignores non 24-hour days #4243

Closed
lemming opened this issue Sep 11, 2023 · 1 comment
Closed

Timepicker ignores non 24-hour days #4243

lemming opened this issue Sep 11, 2023 · 1 comment
Labels

Comments

@lemming
Copy link
Contributor

lemming commented Sep 11, 2023

Bug description

Timepicker assumes that a day consists of 24 hours. But in reality a day is in the range from 23 to 25 hours,
due to daylight saving time (DST) changes in some time zones (e.g. Europe/Amsterdam in 2023).

That behavior causes bugs when special dates (corresponding to DST changes) are selected.

Steps to reproduce

  1. Set your time zone to Europe/Amsterdam
  2. Select 2023-10-29 in datepicker.

This is how this day should look like:

Screenshot from 2023-09-11 09-38-54

This is what we get with react-datepicker:

Duplicated highlight Missing hour
Screenshot from 2023-09-04 10-41-10 Screenshot from 2023-09-04 10-41-32
Timepicker properly renders repeating hour but both hours are considered the same that confuses selection and no matter which one was clicked only the first one will be selected as we render only 24 hours and 2AM happens twice the last hour of the day is missing and it is impossible to select it
Copy link

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 10 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant