Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do away with combo_check and switch to test parametrization #662

Open
3 tasks
agriyakhetarpal opened this issue Dec 2, 2024 · 0 comments
Open
3 tasks
Labels
enhancement This item is useful for the community and the user base and would serve as a fruitful addition PR welcome Contributions towards resolving this issue are welcome

Comments

@agriyakhetarpal
Copy link
Collaborator

the combo_check function predates many improvements made in testing infrastructure over recent years, and is quite dated now. I propose that we refactor the test suite to use pytest better and pave the way for it to be nicer for maintainers and new contributors.

If we were to deprecate the combo_check function and change to a few simple pytest parametrization decorators, we would know exactly what sub-test fails in a test, and where – i.e., which would better isolate the failure instead of us having to do it ourselves.

from @agriyakhetarpal in #643 (comment)

I agree with this idea. Presumably we should be able to get roughly equivalent tests using pytest parameterized tests. If you do implement this it might be worth checking that it doesn't slow the tests down (I like the fact that our tests are really fast).

from @j-towns in #643 (comment)

A task list

  • reimplement combo_check in terms of pytest fixtures and parametrized test methods
  • parametrize tests where possible and where combo_check is used
  • make autograd.test_util a private API where possible
@agriyakhetarpal agriyakhetarpal added enhancement This item is useful for the community and the user base and would serve as a fruitful addition PR welcome Contributions towards resolving this issue are welcome labels Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This item is useful for the community and the user base and would serve as a fruitful addition PR welcome Contributions towards resolving this issue are welcome
Projects
None yet
Development

No branches or pull requests

1 participant