Fix #224: Handle exceptions in server handlers #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Only the last commit is relevant. Will rebase once #219 is merged. |
rdumusc
approved these changes
Jul 28, 2017
tribal-tec
reviewed
Jul 28, 2017
| _send(reply.second.ptr.get(), reply.second.size, 0); | ||
| } | ||
| } | ||
| catch (...) // handler had exception |
There was a problem hiding this comment.
catch std::exception to extract and reply the what() before (...) ?
There was a problem hiding this comment.
Then we'll need to define error codes (e.g. special reply IDs) for the Client. I would vote for doing this when we have a use case.
tribal-tec
approved these changes
Jul 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.