Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spring-cloud-gcp-dependencies BOM forces to use specific version of depenencies #2786

Closed
ivan-zaitsev opened this issue Apr 15, 2024 · 5 comments
Assignees
Labels
priority: p2 type: question Further information is requested

Comments

@ivan-zaitsev
Copy link

ivan-zaitsev commented Apr 15, 2024

Describe the bug
When BOM is used in maven dependencyManagement section it will manage dependencies. It is good for the libraries which are provided by this repository, but for example such library as opentelemetry-bom is not managed by this repository. When spring-cloud-gcp-dependencies is added to dependencyManagement section it overwrites parent opentelemetry version.

Sample
https://mvnrepository.com/artifact/com.google.cloud/spring-cloud-gcp-dependencies/5.1.2
Managed Dependencies section

@suztomo
Copy link
Contributor

suztomo commented Apr 15, 2024

Is this dependency management preventing you from using certain feature of OpenTelemetry?

@ivan-zaitsev
Copy link
Author

The thing is here not about using certain feature, by using spring-cloud-gcp-dependencies in dependencyManagement I don't expect that it will manage additionally opentelemetry or other dependencies that Spring parent manages already. This creates implicit dependency override.

@suztomo
Copy link
Contributor

suztomo commented Apr 15, 2024

opentelemetry or other dependencies that Spring parent manages already

That's interesting. I didn't know that Spring parent manages OpenTelemetry version already. Thanks.

Found: https://docs.spring.io/spring-boot/docs/current/reference/html/dependency-versions.html

Screenshot 2024-04-15 at 1 42 07 PM

@ivan-zaitsev
Copy link
Author

I think that r2dbc-postgresql also managed by Spring.

@diegomarquezp diegomarquezp added type: question Further information is requested priority: p2 labels Apr 16, 2024
@JoeWang1127 JoeWang1127 self-assigned this Jun 12, 2024
@JoeWang1127
Copy link
Contributor

OpenTelemetry is no longer managed by spring-cloud-gcp-dependencies starting from 5.4.0.

googleapis/sdk-platform-java#2736 fixed this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 type: question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants