Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not hide Grpc Exceptions #148

Closed
laurentsenta opened this issue Jan 9, 2018 · 1 comment
Closed

Do not hide Grpc Exceptions #148

laurentsenta opened this issue Jan 9, 2018 · 1 comment

Comments

@laurentsenta
Copy link

I got a cryptic

Could not create publisher stub; no publishes can occur.

from: https://github.com/GoogleCloudPlatform/pubsub/blob/master/kafka-connector/src/main/java/com/google/pubsub/kafka/sink/CloudPubSubGRPCPublisher.java#L38

I just forgot the GOOGLE_APPLICATION_CREDENTIALS env variable, but the catch hides the reason of the exception.

Proposed Fix:
https://github.com/GoogleCloudPlatform/pubsub/pull/147/files
@laurentsenta laurentsenta changed the title Do not catch every Stub Exception Do not hide Grpc Exceptions Jan 9, 2018
@kamalaboulhosn
Copy link
Collaborator

The changes in #152 addressed this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@laurentsenta @kamalaboulhosn