Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Currency conversion after checkout results in HTTP 405 #333

Closed
askmeegs opened this issue Apr 26, 2020 · 1 comment · Fixed by #343
Closed

Currency conversion after checkout results in HTTP 405 #333

askmeegs opened this issue Apr 26, 2020 · 1 comment · Fixed by #343
Assignees

Comments

@askmeegs
Copy link
Contributor

If you click "place order" in the UI with items in your cart, and the success page shows up, then from that success page, try to convert the currency in the top-right, I see an HTTP 405 error.

Solution - make sure the order success page handlers + HTML template are configured to support currency conversion

@askmeegs askmeegs self-assigned this Apr 26, 2020
@ahmetb
Copy link
Contributor

ahmetb commented Apr 29, 2020

Solution - make sure the order success page handlers + HTML template are configured to support currency conversion

I think this is happening because when you change currency, you get redirected to /cart/checkout but with a GET request. However that endpoint does not support GET.

I think the best option would be to hide the currency conversion form on this page through a template variable.

Thanks for finding this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants