Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: also detect sub classes of the SpannerDialect #993

Merged
merged 4 commits into from
Apr 20, 2024

Conversation

olavloite
Copy link
Contributor

@olavloite olavloite commented Apr 8, 2024

This registers the Spanner-specific DDL generation classes, also when a custom subclass of the com.google.cloud.spanner.hibernate.SpannerDialect is used. It also fixes a couple of minor issues with the DDL generation of this dialect:

  1. Constraints are now dropped before tables are dropped.
  2. Indexes on tables were already automatically dropped, but this PR adds an if exists clause to those drop statements to prevent potential failures if the index had already been dropped.

@olavloite olavloite merged commit e1832b5 into master Apr 20, 2024
7 checks passed
@olavloite olavloite deleted the accept-dialect-sub-classes branch April 20, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant