Use a single database connection for monitoring #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing shows that there appears to be an ODPI based leaked somewhere in the godror driver code. Since we cannot update to later versions that might fix this leak due to other problems, create a singleton driver connection to mitigate leaks. bug: 259969026 Change-Id: Idb1a4d4182c6668c4a324ad92851d7ef190ba22c
akinfermo
approved these changes
Nov 28, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akinfermo, kurt-google The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing shows that there appears to be an ODPI based leaked somewhere in the godror driver code. Since we cannot update to later versions that might fix this leak due to other problems, create a singleton driver connection to mitigate leaks.
bug: 259969026
Change-Id: Idb1a4d4182c6668c4a324ad92851d7ef190ba22c