This repository has been archived by the owner on May 15, 2019. It is now read-only.
Add support for Firebase Remote Config events #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmdobry
approved these changes
Oct 26, 2018
|
Thanks for approving @jmdobry What's the process for merging? C/I appears to be failing, but it's failing at master too. I also don't have permission to merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for new event type: Firebase Remote Config
The tests fail with the message "error @google-cloud/[email protected]: The engine "node" is incompatible with this module. Expected version ">=8.0.0"." But it seems like the same thing is also happening on Master.
I don't believe any documentation needs to be updated,since the wiki does not directly mention event types, but please let me know if I need to actually update anything.