Skip to content
This repository has been archived by the owner on May 15, 2019. It is now read-only.

Inspect fails when the supervisor is running on an unexpected port. #204

Merged
merged 2 commits into from
Nov 16, 2018

Conversation

Gwahir
Copy link
Contributor

@Gwahir Gwahir commented Apr 26, 2018

Controller does not pull the active supervisorPort from .active-server.json. This can cause actions like inspect to fail if, as is the case for Firebase serve, the supervisor is running on an unexpected port.

In the pull request, the controller now handles cases where the active supervisor port differs from the config by reading the port value from .active-server.json in the same manner as the rest port.

  • Tests and linter pass - minus gcloud connected tests
  • Code coverage does not decrease (if any source code was changed) - again, minus gcloud elements
  • Appropriate docs were updated (if necessary)

… from the config by reading the port value from .active-server.json in the same manner as the rest port.
@Gwahir
Copy link
Contributor Author

Gwahir commented Apr 26, 2018

Noticed I gave the branch a bad name. Called it controller-serverPort-patch when it should be controller-supervisorPort-patch. Doesn't change the content of the pull request, but I thought I should mention the intent there.

Copy link
Contributor

@jmdobry jmdobry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jmdobry jmdobry merged commit d38d0a0 into googlearchive:master Nov 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants