Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

suggest: recommend @babel/preset-modules for module/nomodule #3129

Closed
connorjclark opened this issue Jun 4, 2020 · 3 comments
Closed

suggest: recommend @babel/preset-modules for module/nomodule #3129

connorjclark opened this issue Jun 4, 2020 · 3 comments
Assignees
Labels
content update for issues that do not require new content (only for updates to existing content) eng - performance issues related to speed stale

Comments

@connorjclark
Copy link
Contributor

These pages were made before @developit created @babel/preset-modules, which is the best way today to build differentially loaded bundles.

Might also be good to mentioned @babel/preset-env+bugfixes: true, but I think @babel/preset-modules is ideal.

https://web.dev/codelab-serve-modern-code/
https://web.dev/serve-modern-code-to-modern-browsers/

@housseindjirdeh

@kaycebasques kaycebasques added content update for issues that do not require new content (only for updates to existing content) eng - performance issues related to speed labels Jun 5, 2020
@connorjclark
Copy link
Contributor Author

So, @babel/preset-env+bugfixes: true is equivalent to preset-modules, and in Babel 8 bugfixes: true will even be the default, so I think we just need to suggest adding bugfixes: true. don't need to mention preset-modules.

@stale
Copy link

stale bot commented Jul 11, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. To prevent this from happening, leave a comment.

@stale stale bot added the stale label Jul 11, 2020
@connorjclark
Copy link
Contributor Author

fixed by #3288

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
content update for issues that do not require new content (only for updates to existing content) eng - performance issues related to speed stale
Projects
None yet
Development

No branches or pull requests

3 participants