Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node.js 16 support - upgrade lighthouse to v7.5.0 #616

Closed
hongbo-miao opened this issue May 24, 2021 · 2 comments
Closed

Node.js 16 support - upgrade lighthouse to v7.5.0 #616

hongbo-miao opened this issue May 24, 2021 · 2 comments

Comments

@hongbo-miao
Copy link

hongbo-miao commented May 24, 2021 •
edited
Loading

It would be great to upgrade lighthouse to v7.5.0.
Because recent lighthouse 7.5.0 has this #596 fixed to allow to using Node.js 16
Thanks!
@hongbo-miao hongbo-miao changed the title Node.js 16 - upgrade lighthouse to v7.5.0 Node.js 16 support - upgrade lighthouse to v7.5.0 May 24, 2021
@hongbo-miao hongbo-miao mentioned this issue May 24, 2021
Closed
3 tasks
@patrickhulce
Copy link
Collaborator

Thanks for filing!

As mentioned in #596 (comment) there is nothing stopping node 16 support aside from just reinstalling/updating package lock deps. Given that Lighthouse version 8 is being released in 2 weeks we'll likely skip 7.5.0.

@hongbo-miao
Copy link
Author

Thanks @patrickhulce ! You are right, reinstalling package-lock.json helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@patrickhulce @hongbo-miao