Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link to default config is outdated #1075

Open
YPCrumble opened this issue Oct 11, 2024 · 2 comments
Open

Link to default config is outdated #1075

YPCrumble opened this issue Oct 11, 2024 · 2 comments
Assignees
@adamraine

Comments

@YPCrumble
Copy link

Thank you for maintaining this great repo!

Just raising a documentation issue that it appears tap-targets has been renamed to target-size and lighthouse-core/config/default-config.js still shows the old config.
@adamraine
Copy link
Member

The lighthouse-core directory has been removed from git tracking for a while now. Are you using an old git repo?

@adamraine adamraine closed this as not planned Won't fix, can't repro, duplicate, stale Oct 11, 2024
@YPCrumble
Copy link
Author

YPCrumble commented Oct 11, 2024 •
edited
Loading

@adamraine thank you! It's actually from the link "default lighthouse config" in this section of the lighthouse-ci docs: https://github.com/GoogleChrome/lighthouse-ci/blob/main/docs/configuration.md#assertions

I suppose that link should be updated to something else?

@adamraine adamraine transferred this issue from GoogleChrome/lighthouse Oct 11, 2024
@adamraine adamraine reopened this Oct 11, 2024
@adamraine adamraine changed the title Default config still shows tap-targets instead of target-size Link to default config is outdated Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamraine adamraine

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adamraine @YPCrumble