Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): don't mutate collect.settings #1068

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dcsaszar
Copy link

@dcsaszar dcsaszar commented Aug 3, 2024

Fixes #1067
Closes #1022

Copy link

google-cla bot commented Aug 3, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@dcsaszar dcsaszar force-pushed the dave-fix-new-headless branch from 5d94ceb to e31ed5b Compare August 3, 2024 15:49
@dcsaszar dcsaszar force-pushed the dave-fix-new-headless branch from e31ed5b to 342b121 Compare August 11, 2024 06:57
@dcsaszar dcsaszar changed the title Don't mutate user settings fix(cli): don't mutate collect.settings Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Second run and beyond falls back to old Chrome headless mode Documentation: How to test a site in dark mode
1 participant