Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Godot 4.x support with class_names #315

Open
joshpinto6 opened this issue Jul 2, 2023 · 11 comments
Open

Godot 4.x support with class_names #315

joshpinto6 opened this issue Jul 2, 2023 · 11 comments
Labels
4.x enhancement New feature or request
Milestone

Comments

@joshpinto6
Copy link

joshpinto6 commented Jul 2, 2023

I'm building a game for a tutorial series I am developing with Godot 4.0 and I am interested in adding godot mod loader to it. However, I found that it was not available for Godot 4.0. Is anyone planning on porting it?
Thanks,

@otDan
Copy link
Member

otDan commented Jul 2, 2023

there are plans for it already, but since no game release on steam that is currently interested in modding uses godot 4, it isn't a priority

@otDan
Copy link
Member

otDan commented Jul 2, 2023

I've created a branch for it, you can follow development:
https://github.com/GodotModding/godot-mod-loader/tree/4.x

@joshpinto6
Copy link
Author

I've created a branch for it, you can follow development: https://github.com/GodotModding/godot-mod-loader/tree/4.x

Thank you!

@joshpinto6 joshpinto6 reopened this Jul 2, 2023
@KANAjetzt KANAjetzt added the enhancement New feature or request label Jul 3, 2023
@KANAjetzt KANAjetzt added this to the v7.0.0 milestone Jul 3, 2023
@KANAjetzt KANAjetzt changed the title Godot 4.0 Support for Godot 4.0 Jul 3, 2023
@Difint
Copy link

Difint commented Jul 15, 2023

Looking forward the port!

@otDan
Copy link
Member

otDan commented Jul 17, 2023

base version is in, now it just needs extensive testing to see if everything is working as expected

@Dark-Peace
Copy link

I'm also interested in using this great plugin for my game in G4

@KANAjetzt KANAjetzt added the 4.x label Sep 16, 2023
@CodingPfeffer
Copy link

I will also use this for a game I am developing with Godot 4.

@KANAjetzt KANAjetzt modified the milestones: v7.0.0, 4.x - 6.2.0 Oct 4, 2023
@Alvarden15
Copy link

Alvarden15 commented Oct 26, 2023

So far the only Godot Modding plugin that supports Godot 4 that i could find (outside of the branch that was created: https://github.com/GodotModding/godot-mod-loader/tree/4.x) is this:
https://github.com/KoBeWi/Godot-Universal-Mod-Manager

@Qubus0
Copy link
Collaborator

Qubus0 commented Oct 26, 2023

Yep. But gumm will have the exact same problem, since it also uses take_over_path to mod scripts - just like we do

@KANAjetzt
Copy link
Member

Update about the 4.x Loader

What does this mean for the current 4.x branch?

  • For most games, the ease of use of the 3.5 loader is gone.
  • The game dev or modder interested in using the current 4.x loader version has to ensure that a named class is only extended once.
  • This can be achieved by creating an "API Mod" that all other mods use.
  • Some experiments to make this process easier are here:
  • So just free-form modding with 4.x will currently most likely end up crashing your game with more than 1 mod installed.

Anything else?

@KANAjetzt KANAjetzt modified the milestones: 4.x - 6.2.0, 4.x - 7.0.0 Jul 2, 2024
@KANAjetzt KANAjetzt changed the title Support for Godot 4.0 Support for Godot 4.x Jul 2, 2024
@Qubus0 Qubus0 changed the title Support for Godot 4.x support scripts using class_name in Godot 4.x Sep 2, 2024
@Qubus0
Copy link
Collaborator

Qubus0 commented Sep 2, 2024

renamed since the mod loader (4.x branch) can be used as normal as long as no class_names are used - as proven by Windowkill

@Qubus0 Qubus0 changed the title support scripts using class_name in Godot 4.x Tracker: Godot 4.x support with class_names Sep 2, 2024
@Qubus0 Qubus0 mentioned this issue Nov 2, 2024
@KANAjetzt KANAjetzt changed the title Tracker: Godot 4.x support with class_names Godot 4.x support with class_names Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

8 participants