Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ggshield should not install its tests #383

Closed
2 tasks
agateau-gg opened this issue Oct 13, 2022 · 0 comments · Fixed by #452
Closed
2 tasks

ggshield should not install its tests #383

agateau-gg opened this issue Oct 13, 2022 · 0 comments · Fixed by #452
Labels
status:confirmed This issue has been reviewed and confirmed type:bug Something isn't working type:infra Issues with our CI setup, packaging, or process

Comments

@agateau-gg
Copy link
Collaborator

agateau-gg commented Oct 13, 2022

Environment

  • ggshield version: 1.13.5
  • Operating system (Linux, macOS, Windows): any
  • Operating system version: any
  • Python version: 3.8.10

Describe the bug

Installing ggshield with pip install installs the tests directory.

Steps to reproduce:

  1. Create and activate a virtualenv
python -m venv bug
  1. Check it contains no tests directory:
ls $VIRTUAL_ENV/lib/python3.8/site-packages/tests
ls: cannot access '/home/agateau/tmp/bug/lib/python3.8/site-packages/tests': No such file or directory
  1. Install ggshield:
pip install ~/src/ggshield

Actual result:

ls $VIRTUAL_ENV/lib/python3.8/site-packages/tests
cmd  core  iac  output  scan  unit

Expected result:

There should be no tests directory in the site-packages directory.

Useful resources

https://setuptools.pypa.io/en/latest/userguide/package_discovery.html

TODO

@agateau-gg agateau-gg added type:bug Something isn't working status:confirmed This issue has been reviewed and confirmed type:infra Issues with our CI setup, packaging, or process labels Oct 13, 2022
@agateau-gg agateau-gg linked a pull request Jan 6, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:confirmed This issue has been reviewed and confirmed type:bug Something isn't working type:infra Issues with our CI setup, packaging, or process
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant