Pass more parameters by reference

GilesBathgate · Jul 27, 2024 · db37389 · db37389
1 parent ed2f8b2
commit db37389
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/src/cgalprimitive.cpp b/src/cgalprimitive.cpp
@@ -269,9 +269,9 @@ CGAL::NefPolyhedron3* CGALPrimitive::createPolyline(const CGAL::Segment3& s)
 	return createPolyline(pl);
 }
 
-CGAL::NefPolyhedron3* CGALPrimitive::createPolyline(QVector<CGAL::Point3> pl)
+CGAL::NefPolyhedron3* CGALPrimitive::createPolyline(const QVector<CGAL::Point3>& pl)
 {
-	using PointRange = QPair<CGAL::Point3*,CGAL::Point3*>;
+	using PointRange = QPair<const CGAL::Point3*,const CGAL::Point3*>;
 	using PolyLine = QVector<PointRange>;
 
 	const PointRange p(&*pl.begin(),&*pl.end());
@@ -1361,7 +1361,7 @@ Primitive* CGALPrimitive::hull(bool concave)
 	return this;
 }
 
-Primitive* CGALPrimitive::hull(QList<CGAL::Point3> pts)
+Primitive* CGALPrimitive::hull(const QList<CGAL::Point3>& pts)
 {
 	CGAL::Object o;
 	CGAL::convex_hull_3(pts.begin(),pts.end(),o);

diff --git a/src/cgalprimitive.h b/src/cgalprimitive.h
@@ -62,7 +62,7 @@ class CGALPrimitive : public Primitive
 	Primitive* glide(Primitive*) override;
 	Primitive* group(Primitive*) override;
 	Primitive* hull(bool) override;
-	Primitive* hull(QList<CGAL::Point3>) override;
+	Primitive* hull(const QList<CGAL::Point3>&) override;
 	Primitive* inset(const CGAL::Scalar&) override;
 	Primitive* intersection(Primitive*) override;
 	Primitive* join(Primitive*) override;
@@ -116,7 +116,7 @@ class CGALPrimitive : public Primitive
 	CGAL::NefPolyhedron3* createPolyline();
 	static CGAL::NefPolyhedron3* createPolyline(CGALPolygon*);
 	static CGAL::NefPolyhedron3* createPolyline(const CGAL::Segment3&);
-	static CGAL::NefPolyhedron3* createPolyline(QVector<CGAL::Point3>);
+	static CGAL::NefPolyhedron3* createPolyline(const QVector<CGAL::Point3>&);
 	CGAL::NefPolyhedron3* createPoints();
 	bool detectHoles(QList<CGALPolygon*>,bool);
 	bool hasHoles();

diff --git a/src/polyhedron.h b/src/polyhedron.h
@@ -42,7 +42,7 @@ class Polyhedron : public Primitive
 	Primitive* glide(Primitive*) override { return this; }
 	Primitive* group(Primitive*) override;
 	Primitive* hull(bool) override { return this; }
-	Primitive* hull(QList<Point>) override { return this; }
+	Primitive* hull(const QList<Point>&) override { return this; }
 	Primitive* inset(const decimal&) override { return this; }
 	Primitive* intersection(Primitive*) override;
 	Primitive* join(Primitive*) override;

diff --git a/src/primitive.h b/src/primitive.h
@@ -54,7 +54,7 @@ class Primitive
 	virtual Primitive* glide(Primitive*)=0;
 	virtual Primitive* group(Primitive*)=0;
 	virtual Primitive* hull(bool)=0;
-	virtual Primitive* hull(QList<Point>)=0;
+	virtual Primitive* hull(const QList<Point>&)=0;
 	virtual Primitive* inset(const decimal&)=0;
 	virtual Primitive* intersection(Primitive*)=0;
 	virtual Primitive* join(Primitive*)=0;