Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Allow the HitNoteScriptEvent/NoteScriptEvent to recieve/get the character who hit the note #3921

Open
2 tasks done
Starexify opened this issue Dec 9, 2024 · 0 comments
Labels
status: pending triage The bug or PR has not been reviewed yet. type: enhancement Provides an enhancement or new feature.

Comments

@Starexify
Copy link

Starexify commented Dec 9, 2024

Issue Checklist

  • I have properly named my enhancement
  • I have checked the Issues/Discussions pages to see if my enhancement has already been suggested

What is your suggestion, and why should it be implemented?

I was trying to somehow get the character who hit the NoteKind with onNoteHit function, but I don't seem to find a way to get the id/character who hit the note. I am not sure if there is any way to make that possible with only onNoteHit event.

Reason for this implementation would be for easier data recieving in events, so NoteKinds are based on the character who hit the note aswell.

If anyone has a way, would also appreciate 👍

Update: I found a way to do this, but I have no idea how optimal it is:

    override function onNoteHit(event:HitNoteScriptEvent) {
        if (event.note.noteData.getMustHitNote()) //   Returns true when if the note is on player side
    }
@Starexify Starexify added status: pending triage The bug or PR has not been reviewed yet. type: enhancement Provides an enhancement or new feature. labels Dec 9, 2024
@Starexify Starexify changed the title Enhancement: Allow the HitNoteScriptEvent/NoteScriptEvent to be able to recieve/get the character who hit the note Enhancement: Allow the HitNoteScriptEvent/NoteScriptEvent to recieve/get the character who hit the note Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: pending triage The bug or PR has not been reviewed yet. type: enhancement Provides an enhancement or new feature.
Projects
None yet
Development

No branches or pull requests

1 participant