Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report: HSV Shader does not change Hue on animated notes #2935

Open
Keoiki opened this issue Jun 29, 2024 · 0 comments
Open

Bug Report: HSV Shader does not change Hue on animated notes #2935

Keoiki opened this issue Jun 29, 2024 · 0 comments
Labels
status: pending triage The bug or PR has not been reviewed yet.

Comments

@Keoiki
Copy link
Contributor

Keoiki commented Jun 29, 2024

Update

My original number 1 problem can be fixed by setting .active = true on the notes which are animated.
It's originally turned false to disable update() for performance reasons but it causes animated notes not working.

(It doesn't fix the shader not changing the hue, that's a different thing)

Describe the bug

1. Using a notestyle with proper animations will not play said animations on the notes.
The animation is supposed to be a gradient moving upwards. (In this case a Red to Orange gradient)
https://github.com/FunkinCrew/Funkin/assets/55053690/23568192-093e-41bc-86b5-011d60716498

  1. Also with animated notes, using the .setHue() function will only change the Value of the note, not the Hue at all.
    (You can see the value being changed on the 2nd/3rd notes because the white part of the note is slightly darker.)
    I have tried this with the vanilla notestyles and the hue changes fine. (Check screenshot further down)
    image_2024-06-29_085519293

To Reproduce

1. Create a notestyle with proper animations for notes and try to play a song with it.
2. Use .setHue() on a note

Expected behavior

1. The animation should play as expected.
https://github.com/FunkinCrew/Funkin/assets/55053690/339cbb49-993b-4848-bfa9-d1bc05d6f68b

  1. The hue should change accordingly. (Check right below this line)

Screenshots/Video

The same pattern of notes with the default Funkin' style.
image_2024-06-29_085722861

The code I used to set note hues:
image_2024-06-29_090221617

Part of the notestyle .json file where note assets are defined:
image_2024-06-29_090253471

Desktop

  • OS: Win10
  • Version: 0.4.1
@Keoiki Keoiki changed the title Bug Report: Animated notestyles not working + HSV Shader on animated notes Bug Report: HSV Shader does not change Hue on animated notes Jul 1, 2024
@EliteMasterEric EliteMasterEric added the status: pending triage The bug or PR has not been reviewed yet. label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: pending triage The bug or PR has not been reviewed yet.
Projects
None yet
Development

No branches or pull requests

2 participants