(chore) - Remove scheduleTask helpers #861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The scheduleTask helper was useful because globally we can't tell whether `Promise` has been polyfilled for IE11 yet. However, where this is called we _can_ already be sure of it being polyfilled, which we do assume in other places of the codebase. Therefore it's safe to replace the `scheduleTask` polyfill with a simple inline `Promise.resolve().then(fn)` call, which is also more obvious.
🦋 Changeset is good to goLatest commit: 5fcf124 We got this. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
JoviDeCroock
approved these changes
Jun 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the
scheduleTaskponyfill helpers in favour of inlinePromise.resolve().then(fn)calls.The scheduleTask helper was useful because globally we can't
tell whether
Promisehas been polyfilled for IE11 yet.However, where this is called we can already be sure of
it being polyfilled, which we do assume in other places
of the codebase.
Therefore it's safe to replace the
scheduleTaskpolyfillwith a simple inline
Promise.resolve().then(fn)call, whichis also more obvious.