Add option to let subscriptionExchange handle all operations

[kitten]

This adds an option to the subscriptionExchange to let it handle query and mutation operations as well.

Resolve #543

[changeset-bot]

🦋 Changeset is good to go

Latest commit: 73bdd69

We got this.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[zenios]

Why don't we use filter function instead? There might be cases (I cannot think of any) where someone wants to pass only subscriptions and mutation via subscription exchange.

[kitten]

I don't think it makes sense to anticipate use-cases that we can't imagine. To a certain extent we tell people that "forking" our exchanges or making more specific ones is fine.

So overall we only implement what we can see as a use-case right now, instead of bloating our API surface 👍 Hope that makes sense to you though

[zenios]

Also it would be nice if we could pass fetchOptions as well. Right now i am using it to pass an authentication header

[kitten]

@zenios Kind of unrelated, but I think that's already possible.

https://github.com/FormidableLabs/urql/blob/73bdd698f72a17840abcc4f38708fda23d1aaee2/packages/core/src/exchanges/subscription.ts#L46-L48

You receive the entire the masked operation with context in forwardSubscription, so you can just use operation.context.fetchOptions

[zenios]

@zenios Kind of unrelated, but I think that's already possible.

https://github.com/FormidableLabs/urql/blob/73bdd698f72a17840abcc4f38708fda23d1aaee2/packages/core/src/exchanges/subscription.ts#L46-L48

You receive the entire the masked operation with context in forwardSubscription, so you can just use operation.context.fetchOptions

Not if fetchOptions is a function

[kitten]

@zenios Like in fetchExchange you can just run the function though

https://github.com/FormidableLabs/urql/blob/8877e0fbc1169405e385579934fc68e1daa49942/packages/core/src/exchanges/fetch.ts#L81-L84

[zenios]

@zenios Like in fetchExchange you can just run the function though

https://github.com/FormidableLabs/urql/blob/8877e0fbc1169405e385579934fc68e1daa49942/packages/core/src/exchanges/fetch.ts#L81-L84

If i use this subsciption exchange and fetchOptions is a function on my server fetchOptions will arrive as [object]

[kitten]

@zenios That sounds like a different problem. You just need to call the function. If you're talking about serialisation, we don't plan or account for context ever to be sent to the server, so this shouldn't happen 😅

Either way, if you need an answer to this feel free to open an issue, where we can discuss this separately. 👍