Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove IE11 support #2504

Merged
merged 24 commits into from
Aug 15, 2022
Merged

feat: Remove IE11 support #2504

merged 24 commits into from
Aug 15, 2022

Conversation

kitten
Copy link
Member

@kitten kitten commented Jun 15, 2022

Summary

This PR aims to comprehensively deprecate the family of urql packages' support of Internet Explorer 11, which has now reached its end of life officially.

Our main focus is that no upgrade is required. We're currently at a stable state and we do not expect that users who need to continue supporting IE11 for a little while longer will need to upgrade immediately.

As part of this change we want to remove code that was added or written in a such a way to enable IE11 support, for compacter alternatives, update our build scripts and tooling, and perform a general cleanup.

Set of changes

  • Update buble transpilation and Terser output config
  • Remove unused babel transformations
  • Fix cjs-module-lexer plugin and improve output
  • Remove IE11 code from @urql/exchange-persisted-fetch

@kitten kitten requested a review from JoviDeCroock June 15, 2022 14:59
@changeset-bot
Copy link

changeset-bot bot commented Jun 15, 2022

🦋 Changeset detected

Latest commit: 0667a26

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 19 packages
Name Type
@urql/exchange-graphcache Major
@urql/exchange-persisted-fetch Major
next-urql Major
@urql/preact Major
urql Major
@urql/storybook-addon Major
@urql/svelte Major
@urql/vue Major
@urql/exchange-auth Major
@urql/exchange-execute Major
@urql/exchange-multipart-fetch Major
@urql/exchange-populate Major
@urql/exchange-refocus Major
@urql/exchange-request-policy Major
@urql/exchange-retry Major
@urql/core Major
@urql/introspection Major
urql-docs Major
@urql/storage-rn Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kitten kitten force-pushed the feat/goodbye-ie11 branch from 3ace2a2 to 32d911e Compare July 24, 2022 01:31
@kitten kitten marked this pull request as ready for review July 29, 2022 09:32
@kitten kitten requested a review from ryan-roemer as a code owner July 29, 2022 09:32
Copy link
Contributor

@ryan-roemer ryan-roemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋

@kitten
Copy link
Member Author

kitten commented Aug 13, 2022

cc @JoviDeCroock: As discussed, this now uses wonka@^6.0.0 which is so far 100% backwards compatible but ported to TypeScript to make external contributions easier and further reduce its bundle size impact.
This is explicitly marked as a major (breaking change) separately. That said, we don't have to mark it as breaking on any exchanges, since it'll only lead to duplicate versions but no breakage. So, we can further discuss how we'd like to handle the changeset itself 🤔

@kitten kitten force-pushed the feat/goodbye-ie11 branch from a9e60d8 to 5959cb5 Compare August 15, 2022 10:10
@kitten kitten force-pushed the feat/goodbye-ie11 branch from ba63be1 to 0667a26 Compare August 15, 2022 22:46
@kitten kitten merged commit 05b6911 into main Aug 15, 2022
@kitten kitten deleted the feat/goodbye-ie11 branch August 15, 2022 22:53
@urql-ci urql-ci mentioned this pull request Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants