(core) - Prevent Buffer from being auto-polyfilled #2027
Conversation
🦋 Changeset detectedLatest commit: cd6c8b1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| typeof Buffer !== 'undefined' && Buffer.isBuffer(input) | ||
| ? input.toString() | ||
| : decoder!.decode(input); | ||
| input.constructor.name === 'Buffer' |
There was a problem hiding this comment.
This is a tricky check without referencing Buffer directly!
I was thinking of a potential alternate of just detecting isBuffer and using it -- also not 100%, but would allow subclasses of Buffer...
typeof input.constructor.isBuffer === 'function' && input.constructor.isBuffer(input)No big deal either way, but just one other thought!
There was a problem hiding this comment.
I'm fine with either 👍 I double checked the Node reference implementation before sending in this change and they seem to just be doing a constructor check, so either should be alright 😄
There was a problem hiding this comment.
I double checked the Node reference implementation before sending in this change and they seem to just be doing a constructor check
Oh haha, that sounds like a good approach then 😂
There was a problem hiding this comment.
Sorry! forgot to add a link: https://github.com/nodejs/node/blob/54e022315d7e037c429afbda73cf8bb8ff96d667/lib/buffer.js#L510
Resolves #2026
Prevent
Bufferfrom being automatically replaced and polyfilled by Webpack's automatic Node.js polyfilling. We achieve this by not using the global and instead check the constructor name of the object we receive.