Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(core) - tweak ExecutionResult to line up with the graphql lib #1998

Merged
merged 2 commits into from
Oct 6, 2021

Conversation

JoviDeCroock
Copy link
Collaborator

Summary

This tweaks the ExecutionResult type to line up with:

Both link to graphql as they reuse this ExecutionResult, should we do too?

Resolves #1989

Set of changes

  • tweak error to GraphQLError

@changeset-bot
Copy link

changeset-bot bot commented Sep 29, 2021

🦋 Changeset detected

Latest commit: 6d308d7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@urql/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@JoviDeCroock JoviDeCroock changed the title tweak ExecutionResult to line up with external libs 5core- = tweak ExecutionResult to line up with the graphql lib Sep 29, 2021
@JoviDeCroock JoviDeCroock changed the title 5core- = tweak ExecutionResult to line up with the graphql lib (core) - tweak ExecutionResult to line up with the graphql lib Sep 29, 2021
@JoviDeCroock JoviDeCroock requested a review from kitten September 29, 2021 16:42
@JoviDeCroock JoviDeCroock merged commit 83f5155 into main Oct 6, 2021
@JoviDeCroock JoviDeCroock deleted the line-errors-up branch October 6, 2021 19:17
@urql-ci urql-ci mentioned this pull request Oct 6, 2021
@lukadriel7
Copy link

hello, is any release integrating this fix planned or a feature must be implemented first?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type error in subscriptionExchange for forwardSubscription
3 participants