(build) - Fix graphql imports for Webpack 5 #1094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 297fe0f The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
kitten
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #1086
Summary
Another week another small ESM issue in Webpack 5. In the upgrade Webpack now supports
package.json:exportsmaps. However, a small problem with this support is how it handles sub-packages without apackage.json:exports. There's a small quirk in Webpack that will require all import paths to be exact (including extensions) even when the sub-package doesn't have apackage.json:exportsmap.We're affected by this because we use our
babel-plugin-modular-graphqlplugin to convert somegraphqlimports into more specific ones. But instead of specifying files likegraphql/language/visitorwe need to add the full path likegraphql/language/visitor.mjs. While I'm not convinced that this is the correct behaviour, it's an easy fix.Set of changes
[email protected]which adds anextensionoptionoutput.plugins. This allows us to merge the two build runs into a single one.babel-plugin-modular-graphqltocleanup()plugin.