fix: Use bytes instead of string comparison in delete validator queue (backport cosmos/cosmos-sdk#12303) #1301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Please ignore CLA. |
0Tech
commented
Mar 26, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1301 +/- ##
==========================================
- Coverage 70.43% 70.43% -0.01%
==========================================
Files 643 643
Lines 54724 54726 +2
==========================================
Hits 38544 38544
- Misses 14009 14010 +1
- Partials 2171 2172 +1
|
0Tech
requested review from
tkxkd0159,
zemyblue and
jaeseung-bae
as code owners
|
Please ignore coverage on panic scenarios. |
jaeseung-bae
previously approved these changes
Mar 26, 2024
jaeseung-bae
approved these changes
Mar 26, 2024
tkxkd0159
approved these changes
Mar 26, 2024
mergify bot
pushed a commit
that referenced
this pull request
Mar 26, 2024
… (backport cosmos/cosmos-sdk#12303) (#1301) * fix : Use bytes instead of string comparison in delete validator queue (#12303) * Update CHANGELOG.md * Update CHANGELOG.md --------- Co-authored-by: William Chong <[email protected]> (cherry picked from commit 1038a39) # Conflicts: # CHANGELOG.md
5 tasks
0Tech
added a commit
that referenced
this pull request
Mar 29, 2024
… (backport cosmos/cosmos-sdk#12303) (backport #1301) (#1309) * fix: Use bytes instead of string comparison in delete validator queue (backport cosmos/cosmos-sdk#12303) (#1301) * fix : Use bytes instead of string comparison in delete validator queue (#12303) * Update CHANGELOG.md * Update CHANGELOG.md --------- Co-authored-by: William Chong <[email protected]> (cherry picked from commit 1038a39) # Conflicts: # CHANGELOG.md * Update CHANGELOG.md --------- Co-authored-by: Youngtaek Yoon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cherry-pick of:
Motivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yaml