fix: add nft id validation to MsgSendNFT #1287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulbqb
force-pushed
the
fix/sendnftmsg_validation
branch
from
10af857 to
ecf227e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1287 +/- ##
=======================================
Coverage 69.74% 69.74%
=======================================
Files 643 643
Lines 67261 67266 +5
=======================================
+ Hits 46909 46917 +8
+ Misses 18179 18177 -2
+ Partials 2173 2172 -1
|
ulbqb
changed the title
ulbqb
force-pushed
the
fix/sendnftmsg_validation
branch
from
2349669 to
5b47966
Compare
ulbqb
requested review from
tkxkd0159,
zemyblue,
0Tech and
jaeseung-bae
as code owners
0Tech
approved these changes
Mar 19, 2024
zemyblue
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #XXXX
This PR adds nft id validation to MsgSendNFT.
Motivation and context
The ValidateBasic() method of message MsgSendNFT is used to check the validity of the message during the stateless validation process. The current implementation of ValidateBasic() checks whether the provided IDs are valid TokenIDs with function ValidateTokenID():
It is insufficient as it allows Fungible tokens to pass through, potentially leading to unexpected errors since Fungible tokens are not intended to be processed by this function.
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yaml