Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(linting): lint all files based on latest setting #1171

Merged
merged 19 commits into from
Nov 8, 2023
Merged

chore(linting): lint all files based on latest setting #1171

merged 19 commits into from
Nov 8, 2023

Conversation

tkxkd0159
Copy link
Member

@tkxkd0159 tkxkd0159 commented Nov 3, 2023 •
edited
Loading

Description

closes: #819

  • Apply upstream lint settings to finschia-sdk
  • Fix all files based on the result of linting

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@tkxkd0159 tkxkd0159 requested a review from zemyblue as a code owner November 3, 2023 10:28
@tkxkd0159 tkxkd0159 self-assigned this Nov 3, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 3, 2023 •
edited
Loading

Codecov Report

Merging #1171 (13d1225) into main (e45b246) will decrease coverage by 0.06%.
Report is 2 commits behind head on main.
The diff coverage is 68.35%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1171      +/-   ##
==========================================
- Coverage   69.76%   69.71%   -0.06%     
==========================================
  Files         646      646              
  Lines       67591    67637      +46     
==========================================
- Hits        47157    47152       -5     
- Misses      18246    18284      +38     
- Partials     2188     2201      +13
Files Coverage Δ
baseapp/abci.go 58.14% <100.00%> (+0.08%) ⬆️
baseapp/baseapp.go 79.17% <ø> (-0.05%) ⬇️
baseapp/reactor.go 11.11% <ø> (+0.39%) ⬆️
client/cmd.go 58.95% <ø> (ø)
client/context.go 53.93% <ø> (ø)
client/flags/flags.go 89.47% <100.00%> (ø)
client/grpc/tmservice/block.go 63.63% <ø> (ø)
client/keys/add.go 70.00% <100.00%> (ø)
client/keys/delete.go 71.79% <ø> (ø)
client/keys/parse.go 77.01% <ø> (ø)
... and 120 more

... and 37 files with indirect coverage changes

@tkxkd0159 tkxkd0159 changed the title chore: lint all files based on latest setting chore(linting): lint all files based on latest setting Nov 3, 2023
zemyblue
zemyblue reviewed Nov 6, 2023
View reviewed changes
client/keys/import_test.go Show resolved Hide resolved
x/feegrant/module/module.go Show resolved Hide resolved
x/slashing/keeper/keeper_test.go Show resolved Hide resolved
x/upgrade/abci_test.go Show resolved Hide resolved
x/upgrade/types/storeloader_test.go Show resolved Hide resolved
jaeseung-bae
jaeseung-bae reviewed Nov 7, 2023
View reviewed changes
baseapp/abci.go Outdated Show resolved Hide resolved
client/flags/flags.go Show resolved Hide resolved
client/config/config_test.go Show resolved Hide resolved
client/flags/flags.go Show resolved Hide resolved
codec/any_test.go Outdated Show resolved Hide resolved
@tkxkd0159 tkxkd0159 merged commit d232bd6 into main Nov 8, 2023
36 of 37 checks passed
@tkxkd0159 tkxkd0159 deleted the lint-all branch November 8, 2023 04:46
@jaeseung-bae jaeseung-bae mentioned this pull request Dec 26, 2023
Open
96 tasks
@jaeseung-bae jaeseung-bae mentioned this pull request Jan 17, 2024
Open
@jaeseung-bae jaeseung-bae mentioned this pull request Mar 23, 2024
Merged
5 tasks
jaeseung-bae pushed a commit to jaeseung-bae/finschia-sdk that referenced this pull request May 7, 2024
@tkxkd0159 @jaeseung-bae
chore(linting): lint all files based on latest setting (Finschia#1171)
97f3b58 
* lint: nakedret

* lint: thelper

* lint: autofix

* lint: test

* lint: autofix

* lint: unused

* lint: unconvert

* lint: stylecheck

* lint: staticcheck

* lint: ineffassign

* lint: govet

* lint: gosimple

* lint: gosec

* lint: gofumpt

* lint: gocritic

* lint: goconst

* lint: errcheck

* lint: nolintlint

* fix
tkxkd0159 added a commit that referenced this pull request Jun 19, 2024
@tkxkd0159
Backport #1171
888642a
tkxkd0159 added a commit that referenced this pull request Jun 24, 2024
@tkxkd0159
style: Lint all files based on latest setting (backport #1171, #1414) (…
237cb84 
…#1427)

* Backport #1171

* Apply `gci`

* Backport #1414

* Add CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeseung-bae jaeseung-bae jaeseung-bae approved these changes

@zemyblue zemyblue zemyblue approved these changes

@0Tech 0Tech Awaiting requested review from 0Tech 0Tech is a code owner

Assignees

@tkxkd0159 tkxkd0159

Labels
A: CI C:baseapp C:client C:codec C:crypto C:server C:simapp C:snapshots C:store C:testutil C:x/auth C:x/authz C:x/bank C:x/bankplus C:x/capability C:x/collection C:x/crisis C:x/distribution C:x/evidence C:x/feegrant C:x/foundation x/foundation module C:x/genutil C:x/gov C:x/mint C:x/slashing C:x/staking C:x/stakingplus C:x/token C:x/upgrade
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

all lbm-sdk codebase must be gofmt-ed
4 participants
@tkxkd0159 @zemyblue @0Tech @jaeseung-bae