Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace ExactArgs(0) with NoArgs #1168

Merged
merged 3 commits into from
Nov 1, 2023
Merged

chore: replace ExactArgs(0) with NoArgs #1168

merged 3 commits into from
Nov 1, 2023

Conversation

tkxkd0159
Copy link
Member

@tkxkd0159 tkxkd0159 commented Oct 31, 2023

Description

closes: #743

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@tkxkd0159 tkxkd0159 self-assigned this Oct 31, 2023
@tkxkd0159 tkxkd0159 added A: improvement Changes in existing functionality C:x/upgrade labels Oct 31, 2023
@tkxkd0159 tkxkd0159 changed the title chore: replace ExactArgs(0) with `NoArgs() chore: replace ExactArgs(0) with NoArgs() Oct 31, 2023
@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #1168 (a719b73) into main (ca35eab) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1168   +/-   ##
=======================================
  Coverage   69.76%   69.76%           
=======================================
  Files         646      646           
  Lines       67591    67591           
=======================================
  Hits        47157    47157           
  Misses      18246    18246           
  Partials     2188     2188           

jaeseung-bae
jaeseung-bae previously approved these changes Oct 31, 2023
@tkxkd0159 tkxkd0159 changed the title chore: replace ExactArgs(0) with NoArgs() chore: replace ExactArgs(0) with NoArgs Oct 31, 2023
0Tech
0Tech previously approved these changes Oct 31, 2023
@tkxkd0159 tkxkd0159 dismissed stale reviews from 0Tech and jaeseung-bae via a719b73 October 31, 2023 09:42
@tkxkd0159 tkxkd0159 merged commit e45b246 into main Nov 1, 2023
37 checks passed
@tkxkd0159 tkxkd0159 deleted the chore-cobra branch November 1, 2023 01:44
jaeseung-bae pushed a commit to jaeseung-bae/finschia-sdk that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: improvement Changes in existing functionality C:x/upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code hygiene: address the inconsistency in the validations on the number of arguments
3 participants