You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Redefine cosmos proto changed in lbm to lbm's proto
Problem Definition
We are modifying the original cosmos-sdk's protobuf files, but there are compatibility issues. So we need to roll back to cosmos-sdk's proto or separate the changed message to a custom lbm proto.
changed messages
base.abci.v1beta1.abci.TxResponse: add index
tx.v1beta1.service.GetBlockWithTxsResponse: Block is ostracon's Block
Proposal
Use new lbm proto message for the changed cosmos-sdk proto messages.
lbm.base.abci.v1beta1.abci.TxResponse
It's a best solution that remove index.
If not, add lbm service query, and response not supported in cosmos.base.abci.v1beta1.Service.
lbm.tx.v1beta1.Service
add lbm.tx.v1beta1.Service/GetBlockWithTxs
response ignored or not supported in cosmos.tx.v1beta1.Service/GetBlockWithTxs
lbm/tx/v1beta1/service.proto
// Service defines a gRPC service for interacting with transactions.serviceService {
// GetBlockWithTxs fetches a block with decoded txs.//// Since: lbm-sdk 0.47.0rpcGetBlockWithTxs(GetBlockWithTxsRequest) returns (GetBlockWithTxsResponse) {
option(google.api.http).get="/lbm/tx/v1beta1/txs/block/{height}";
}
}
// GetBlockWithTxsRequest is the request type for the Service.GetBlockWithTxs// RPC method.//// Since: cosmos-sdk 0.45.2messageGetBlockWithTxsRequest {
// height is the height of the block to query.int64height=1;
// pagination defines a pagination for the request.cosmos.base.query.v1beta1.PageRequestpagination=2;
}
// GetBlockWithTxsResponse is the response type for the Service.GetBlockWithTxs method.//// Since: lbm-sdk 0.47.0messageGetBlockWithTxsResponse {
// txs are the transactions in the block.repeatedcosmos.tx.v1beta1.Txtxs=1;
.tendermint.types.BlockIDblock_id=2;
.ostracon.types.Blockblock=3;
// pagination defines a pagination for the response.cosmos.base.query.v1beta1.PageResponsepagination=4;
}
For Admin Use
Not duplicate issue
Appropriate labels applied
Appropriate contributors tagged
Contributor assigned/self-assigned
The text was updated successfully, but these errors were encountered:
Summary
Redefine cosmos proto changed in lbm to lbm's proto
Problem Definition
We are modifying the original cosmos-sdk's protobuf files, but there are compatibility issues. So we need to roll back to cosmos-sdk's proto or separate the changed message to a custom lbm proto.
changed messages
Proposal
Use new lbm proto message for the changed cosmos-sdk proto messages.
lbm.base.abci.v1beta1.abci.TxResponse
index
.cosmos.base.abci.v1beta1.Service
.lbm.tx.v1beta1.Service
lbm.tx.v1beta1.Service/GetBlockWithTxs
cosmos.tx.v1beta1.Service/GetBlockWithTxs
lbm/tx/v1beta1/service.proto
For Admin Use
The text was updated successfully, but these errors were encountered: